Open
Conversation
majst01
force-pushed
the
network-services
branch
from
684359f to
0562727
Compare
iljarotar
reviewed
Feb 19, 2026
| }, | ||
| // State: &0, | ||
| }, | ||
| Partition: nil, // again partition? |
Contributor
There was a problem hiding this comment.
Suggested change
| Partition: nil, // again partition? | |
| // admins are allowed to list machines in all partitions | |
| Partition: nil, |
iljarotar
reviewed
Feb 19, 2026
| Image: pointer.PointerOrNil(viper.GetString("image")), | ||
| FilesystemLayout: pointer.PointerOrNil(viper.GetString("file-system-layout-id")), | ||
| Hostname: pointer.PointerOrNil(viper.GetString("hostname")), | ||
| // AllocationType: &0, |
Contributor
There was a problem hiding this comment.
Suggested change
| // AllocationType: &0, | |
| // AllocationType: &0, TODO: implement |
iljarotar
reviewed
Feb 19, 2026
| Nic: &apiv2.MachineNicQuery{}, | ||
| Disk: &apiv2.MachineDiskQuery{ | ||
| Names: viper.GetStringSlice("disk-names"), | ||
| // Sizes: |
Contributor
There was a problem hiding this comment.
Suggested change
| // Sizes: | |
| // Sizes: TODO: implement |
iljarotar
reviewed
Feb 19, 2026
| Memory: pointer.PointerOrNil(viper.GetUint64("memory")), | ||
| CpuCores: pointer.PointerOrNil(viper.GetUint32("cpu-cores")), | ||
| }, | ||
| // State: &0, |
Contributor
There was a problem hiding this comment.
Suggested change
| // State: &0, | |
| // State: &0, TODO: implement |
iljarotar
reviewed
Feb 19, 2026
| Labels: tag.NewTagMap(viper.GetStringSlice("labels")), | ||
| }, | ||
| Type: nwType, | ||
| // NatType: (*apiv2.NATType)(nwType), |
Contributor
There was a problem hiding this comment.
Suggested change
| // NatType: (*apiv2.NATType)(nwType), | |
| // NatType: (*apiv2.NATType)(nwType), TODO: implement |
iljarotar
reviewed
Feb 19, 2026
| DestinationPrefixes: r.DestinationPrefixes, | ||
| DefaultChildPrefixLength: r.DefaultChildPrefixLength, | ||
| MinChildPrefixLength: r.MinChildPrefixLength, | ||
| // NatType: &0, |
Contributor
There was a problem hiding this comment.
Suggested change
| // NatType: &0, | |
| // NatType: &0, TODO: implement |
iljarotar
reviewed
Feb 19, 2026
Comment on lines
+297
to
+300
| var vrf *uint32 | ||
| if viper.IsSet("vrf") { | ||
| vrf = new(viper.GetUint32("vrf")) | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| var vrf *uint32 | |
| if viper.IsSet("vrf") { | |
| vrf = new(viper.GetUint32("vrf")) | |
| } |
iljarotar
reviewed
Feb 19, 2026
| DefaultChildPrefixLength: defaultCPL, | ||
| MinChildPrefixLength: minCPL, | ||
| NatType: &natType, | ||
| Vrf: vrf, |
Contributor
There was a problem hiding this comment.
Suggested change
| Vrf: vrf, | |
| Vrf: pointer.PointerOrNil(viper.GetUint32("vrf")), |
iljarotar
reviewed
Feb 19, 2026
| } | ||
|
|
||
| return resp.Size, nil | ||
| } |
iljarotar
reviewed
Feb 19, 2026
| func (c *size) List() ([]*apiv2.Size, error) { | ||
| panic("unimplemented") | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
None